Update ToC getting hidden behind SubNavBar on scroll. #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bgravenorst <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the Table of Contents (ToC) "On this page" section was getting hidden behind the sticky SubNavBar when scrolling on Embedded Wallets pages.
[class*='tableOfContents']for better CSS modules compatibility:has()to increase the ToC offset only when the SubNavBar is presentIssue(s) fixed
Fixes #2545
Preview
https://metamask-docs-git-doc-2545-consensys-ddffed67.vercel.app/smart-accounts-kit
Checklist
Note
Switches ToC styling to a CSS-modules-safe selector and increases sticky top offsets, with a larger offset when a SubNavBar is present.
[class*='tableOfContents']for CSS modules compatibility insrc/scss/theme/_toc.scss.topoffset fromvar(--ifm-navbar-height) + 2remto+ 4rem.body:has([class*='subNavBar']) [class*='tableOfContents'] { top: calc(var(--ifm-navbar-height) + 9rem) }to clear the SubNavBar.Written by Cursor Bugbot for commit 6d4b19c. This will update automatically on new commits. Configure here.